Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[5.7] Use Request::validate() macro in Auth traits #26314
This PR uses the
This is technically a breaking change because it's possible for an installation not to include
This change will silently stop calling people's overridden LoginController::validate method. It's basically a huge silent change in behavior. Code that has worked for ages are suddenly no longer invoked, and custom validation of user-data in authentication controllers is no longer performed. There's no exception, nothing logged, that the custom security checks implemented for the last few years (since Laravel 5.0) is no longer checked.
A breaking change doesn't mean that the new code will not work. This is not only a breaking change because the small possibility that the FoundationServiceProvider is missing; it's a enormous breaking change because any existing application logic needs to be refactored into new places to have effect again.
I'm sympathetic and willing to submit this for 5.8.
However, in defense of the change, overriding