New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Updating AbstractPaginator::appends to handle null #26326

Merged
merged 2 commits into from Oct 31, 2018

Conversation

Projects
None yet
2 participants
@pfuhrmann
Contributor

pfuhrmann commented Oct 31, 2018

This method is most commonly used with $request->query() which recently changed docblock [1] also to return null. Same as original commit, this is to make PHPStan happy.

$events = $query->paginate($perPage);
$events->appends($request->query());

[1] #25954

pfuhrmann added some commits Oct 31, 2018

[5.7] Updating AbstractPaginator::appends to handle null
This method is most commonly used with `$request->query()` which recently changed docblock [1] also to return `null`. Same as original commit, this is to make PHPStan happy.

```
$events = $query->paginate($perPage);
$events->appends($request->query());
```

[1] #25954

@taylorotwell taylorotwell merged commit 0060d98 into laravel:5.7 Oct 31, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pfuhrmann pfuhrmann deleted the pfuhrmann:patch-1 branch Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment