New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Adds missing logging options to slack log driver #26360

Merged
merged 2 commits into from Nov 2, 2018

Conversation

Projects
None yet
2 participants
@dpsarrou
Contributor

dpsarrou commented Nov 2, 2018

Usecase

Hide some fields from the Slack message (eg. PII), when Slack is used as a Log driver.

More info

While you can define a property excludeFields in your logging.php config file, this is not taken into account when Slack is used as a log driver. The method of LogManager that creates the Slack driver does not pass this information to SlackWebhookHandler even though the later can support it. This PR addresses this by adding the missing fields.

Note

The default values have been set to match the ones found at the constructor of SlackWebhookHandler.

@taylorotwell

This comment has been minimized.

Member

taylorotwell commented Nov 2, 2018

Laravel configuration is always snake case so excludeFields should be exclude_fields.

@dpsarrou

This comment has been minimized.

Contributor

dpsarrou commented Nov 2, 2018

@taylorotwell Thanks, updated. Can you also guide me on where I could possibly document this feature?

@taylorotwell taylorotwell merged commit 7daaa46 into laravel:5.7 Nov 2, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/styleci/pr The analysis has passed
Details
@taylorotwell

This comment has been minimized.

Member

taylorotwell commented Nov 2, 2018

Probably laravel/docs notifications.md

@dpsarrou dpsarrou deleted the dpsarrou:5.7-adds_missing_logging_options_for_slack_driver branch Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment