[5.7] Adds missing logging options to slack log driver #26360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Laravel configuration is always snake case so |
|
@taylorotwell Thanks, updated. Can you also guide me on where I could possibly document this feature? |
|
Probably laravel/docs notifications.md |
dpsarrou
deleted the
5.7-adds_missing_logging_options_for_slack_driver
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usecase
Hide some fields from the Slack message (eg. PII), when Slack is used as a Log driver.
More info
While you can define a property
excludeFieldsin yourlogging.phpconfig file, this is not taken into account when Slack is used as a log driver. The method ofLogManagerthat creates the Slack driver does not pass this information to SlackWebhookHandler even though the later can support it. This PR addresses this by adding the missing fields.Note
The default values have been set to match the ones found at the constructor of SlackWebhookHandler.