[5.7] Add "some" method to Collection as an alias to "contains"

[paras-malhotra]

After going through the Collections documentation, I couldn't find an any method, especially after observing that an every method does exist!

After quite a long code walkthrough, I found that contains would the equivalent of any. However, it's not quite apparent especially from a predicate callback perspective. I think adding any as an alias to contains would be very helpful. Since this is an additional method, there are no breaking changes.

[devcircus]

Based on other methods in the framework, I would expect an 'any' method to accept multiple parameters and return whether or not the collection contains "any" of those. It doesn't feel like any == contains.

[paras-malhotra]

IMO, a method that returns whether or not a collection contains any params, sounds like a where or a whereAny.

I'll demonstrate why I think any is a perfect alias for contains. Mentioned below are some use cases:

1. Check if any order has a book product:

$orders->any('product', 'book');

2. Check if any order has more than 5 items:

$orders->any('quantity', '>', 5);

3. Check if any order was paid by cash (truth test):

$orders->any(function($order) {
    return $order->paymentMethod() === 'cash';
});

All of the above use cases look perfect for an any method. What's more is that they're similar to every that has all the above use cases in a different context.

That's why I think any should be an alias for contains.

[phanan]

@paras-malhotra I think the term you're looking for here is some instead of any, knowing that:

• every will return true if all predicate is true
• some will return true if any predicate is true

[paras-malhotra]

@phanan I agree. I checked the documentation of both Lodash and Underscore JS. Both of them have every and some methods that do the same thing that we're trying to do! I think this naming would also get rid of the confusion that @devcircus mentioned.

I'll update my PR to rename the method to some.