Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Ability to disable password reset route #26459

Merged
merged 2 commits into from
Nov 9, 2018

Conversation

LucaRed
Copy link
Contributor

@LucaRed LucaRed commented Nov 9, 2018

#25556 added the ability to disable the registration routes using the $options parameter.

For consistency, this pull request adds the ability to disable the password reset routes. For example, this can be useful in apps that don't allow user initiated password resets for security reasons.

@ankurk91
Copy link
Contributor

ankurk91 commented Nov 9, 2018

I think there should be a command to publish all auth related routes to routes/web.php, then people will be able to choose what to keep and what to delete.

@taylorotwell taylorotwell merged commit 831e4eb into laravel:5.7 Nov 9, 2018
@emko80
Copy link

emko80 commented Nov 14, 2018

Hello,

could you please tell me why the fix is missing when laravel is installed using composer. I have installed it twice with and without --prefer-dist option and still is missing there.... artisan --version showed 5.7.13

Thx

@LucaRed
Copy link
Contributor Author

LucaRed commented Nov 14, 2018

@emko80 the latest Laravel version (v5.7.13) was released before this commit. You have to wait for the next release.

@devcircus
Copy link
Contributor

With just a couple of keystrokes you can copy the routes from source and choose which ones you want to use. I don’t really understand these PRs. Better yet, make an ide/editor template. You really shouldn’t hide your routes anyway. Be explicit. JMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants