Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Improve whereInRaw() #26471

Merged
merged 1 commit into from Nov 11, 2018
Merged

[5.7] Improve whereInRaw() #26471

merged 1 commit into from Nov 11, 2018

Conversation

staudenmeir
Copy link
Contributor

@staudenmeir staudenmeir commented Nov 10, 2018

The whereInRaw() method hasn't been released yet, we can still change it:

  • Renames it to whereInRawInt() to make its purpose and limitations obvious.
  • Removes the array type hint to support Arrayable values. This is consistent with whereIn().
  • Replaces array_map() with a foreach loop which is considerably faster. Since the whole point of this method is the performance improvement, we shouldn't waste time here.

Thanks to @vlakoff.

@vlakoff
Copy link
Contributor

vlakoff commented Nov 10, 2018

Refs #26434 (and #26453).

  • Travis CI failures seem to be unrelated.
  • I'd rather name it whereInRawInts, let's let Taylor settle for this.

@taylorotwell taylorotwell merged commit d10b0a5 into laravel:5.7 Nov 11, 2018
@vlakoff
Copy link
Contributor

vlakoff commented Nov 15, 2018

Refs the subsequent a3738cf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants