[5.7] Allow MorphTo relations to specify select columns #26483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are failing. Can you add tests? |
driesvints
changed the title
|
@jmarcher tests are currently failing on multiple branches for a different reason. Not sure what's going on. |
driesvints
previously requested changes
Nov 12, 2018
|
Thanks for fixing my style issue. I thought StyleCI automaticly fixed these issues. I'm sorry but I do not know how to write a test for this. |
|
#25662 should have already fixed that. Can you provide an example that didn't work before this PR? |
|
This does work indeed. I forgot to update. I'm sorry for wasting your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When eager loading relations with the
withfunction, one can alter the query used to retrieve the related models with a closure. With normal relations you can select the columns which will be retrieved from the database, but with MorphTo relationships you can not.My small change only allows column selection in eager loading MorphTo relations.