[5.8] Fix FormRequest validate not twice. #26486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
reviewed
Nov 12, 2018
| @@ -172,7 +181,7 @@ protected function failedAuthorization() | |||
| */ | |||
| public function validated() | |||
| { | |||
| return $this->getValidatorInstance()->validated(); | |||
| return $this->validator->validated(); | |||
There was a problem hiding this comment.
What if you call this method before the validator is set? I think we should think this through more.
There was a problem hiding this comment.
@driesvints
Thanks for checking.
ValidatesWhenResolvedTrait::validateResolved() is called in FormRequestServiceProvider::boot() afterResolving.
So I think that it is normally set.
There was a problem hiding this comment.
can't this be fixed by adding a simple if statement that can be added to the getValidatorInstance?
There was a problem hiding this comment.
@mohammedmanssour
I think so too, but getValidatorInstance called twice.
We require single validator instance.
ttsuru
changed the title
taylorotwell
pushed a commit
that referenced
this pull request
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to #26419
Fix validate method.
refs #25736