New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.7] Code improvements for TestResponse::parseJsonWhilePreservingEmptyObjects #26508

Merged

taylorotwell merged 2 commits into laravel:5.7 from vlakoff:TestResponse

Nov 14, 2018

Contributor

vlakoff commented Nov 13, 2018

Follow-up to #26353 (and e6ebc8d).

Avoids doing the object-to-array cast twice (such cast can be somewhat costly)
Avoids the nested method call, mainly for simplification, and also for performance

vlakoff added 2 commits

November 13, 2018 20:46


          Store object-to-array cast to not do it twice

c83f28a


          Rewrite to avoid nested calls of parseJsonWhilePreservingEmptyObjects()

2afd299

taylorotwell merged commit ae04918 into laravel:5.7

vlakoff deleted the TestResponse branch

November 15, 2018 03:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment