New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Changing the Migrator to accept not only migration directory paths, but migration file paths too #26642

Merged
merged 3 commits into from Nov 28, 2018

Conversation

Projects
None yet
2 participants
@gabfr
Contributor

gabfr commented Nov 27, 2018

Hi!

First of all, thanks for such a great framework. I did a small one-line-change that I believe that may be useful for other folks too.

I changed the way the method Illuminate\Database\Migrations\Migrator::getMigrations flatMap the array of paths, by considering checking for file paths and not only assuming directory paths.

Initially I made this change because I maintain an app that has migrations inside different folders (separated by modules), so I had to edit the way the migrations is runned (to not run into an out-of-sequence-migration problem) by a third-party package command (tenant:migrate - you can see the PR by clicking here)

@driesvints driesvints changed the title from Changing the Migrator to accept not only migration directory paths, but migration file paths too to [5.7] Changing the Migrator to accept not only migration directory paths, but migration file paths too Nov 27, 2018

@taylorotwell taylorotwell merged commit f5e3d7f into laravel:5.7 Nov 28, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment