[5.7] Changing the Migrator to accept not only migration directory paths, but migration file paths too #26642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
First of all, thanks for such a great framework. I did a small one-line-change that I believe that may be useful for other folks too.
I changed the way the method
Illuminate\Database\Migrations\Migrator::getMigrationsflatMap the array of paths, by considering checking for file paths and not only assuming directory paths.Initially I made this change because I maintain an app that has migrations inside different folders (separated by modules), so I had to edit the way the migrations is runned (to not run into an out-of-sequence-migration problem) by a third-party package command (
tenant:migrate- you can see the PR by clicking here)