New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Prevent breaking eager loading with "incrementing" string keys #26688

Merged
merged 1 commit into from Nov 30, 2018

Conversation

Projects
None yet
2 participants
@staudenmeir
Contributor

staudenmeir commented Nov 30, 2018

The fix from #26622 caused a new issue (#26683): Some people are using $incrementing = true and $keyType = 'string' to automatically get uuids that are generated by the database.

So we can only apply the eager loading improvement to models with auto-incrementing and integer primary keys.

Fixes #26683.

@taylorotwell taylorotwell merged commit 86131d6 into laravel:5.7 Nov 30, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@staudenmeir staudenmeir deleted the staudenmeir:eager-loading branch Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment