[5.7] Extract Nexmo and Slack drivers to own package

[themsaid]

The channels were extracted to:

https://github.com/laravel/slack-notification-channel
https://github.com/laravel/nexmo-notification-channel

[koenhoeijmakers]

Why not in https://github.com/laravel-notification-channels as the docs still reference to it as a sort of "collection of all notification channels"?

[devcircus]

That’s a “community” driven repo. These are official Laravel packages.

[koenhoeijmakers]

Can totally understand that.

It's just that laravel-notification-channels doesn't seem that active in the form of adding new channels as the oldest new channel PR dates from Sep 6, 2016 and that this might have been a point to pick that up again.

[taylorotwell]

We need to add them to the framework composer.json I guess? And then remove them in 5.8 and people opt-in.

[laurencei]

Seems very strange to be doing this on a point release (even if its not breaking). Why not leave the whole change until 5.8 entirely?

[themsaid]

@taylorotwell added to the framework's composer.json file.

[laurencei]

@themsaid - Travis is failing with "Your requirements could not be resolved to an installable set of packages"

[themsaid]

@laurencei yes, for now. We'll need to publish the libraries on packagist first.

[taylorotwell]

@themsaid Are we going to move the tests to the repos?

[taylorotwell]

Both packages have been added to Composer.

[themsaid]

@taylorotwell build is passing now. Also added tests to the packages.

[mfn]

Seems very strange to be doing this on a point release (even if its not breaking). Why not leave the whole change until 5.8 entirely?

My thoughts exactly. What's the rush here, really? Just do it in-time for master.

[taylorotwell]

@mfn @laurencei Because I want to do it now? Do you have a reason why we shouldn't? It's not a breaking change in any way unless I'm mistaken?

[laurencei]

It felt strange initially - and then I considered the fact that the framework is essentially a bunch of packages, and so in that respect it makes sense. I agree there is no breaking change that I can think of either.

[taylorotwell]

@themsaid do you want to tag 1.0.0 on both of the packages?

[TBlindaruk]

@taylorotwell , @themsaid , @driesvints ,

Maybe will be better to move this packages with git history?

http://gbayer.com/development/moving-files-from-one-git-repository-to-another-preserving-history/

[driesvints]

@TBlindaruk it's a bit to late for that since we already tagged versions. Didn't know about this. Thanks for sharing! :)

[TBlindaruk]

@driesvints we still can do it )

Like:

1. delete files from the package
2. moved files with the history

;)

[stevebauman]

This seems to have broken my Laravel 5.7 app.

Downgrading to Laravel 5.7.15 works without issue, but as soon as I upgrade to Laravel 5.7.16 it breaks:

As soon as I run composer update targeting 5.7.16, this happens:

Package operations: 13 installs, 1 update, 0 removals
  - Installing guzzlehttp/promises (v1.3.1): Loading from cache
  - Installing ralouphie/getallheaders (2.0.5): Loading from cache
  - Installing psr/http-message (1.0.1): Loading from cache
  - Installing guzzlehttp/psr7 (1.5.2): Loading from cache
  - Installing guzzlehttp/guzzle (6.3.3): Loading from cache
  - Installing laravel/slack-notification-channel (v1.0.2): Loading from cache
  - Updating laravel/framework (v5.7.15 => v5.7.16): Loading from cache
  - Installing lcobucci/jwt (3.2.5): Loading from cache
  - Installing php-http/promise (v1.0.0): Loading from cache
  - Installing php-http/httplug (v1.1.0): Loading from cache
  - Installing php-http/guzzle6-adapter (v1.1.1): Loading from cache
  - Installing zendframework/zend-diactoros (1.8.6): Loading from cache
  - Installing nexmo/client (1.5.2): Loading from cache
  - Installing laravel/nexmo-notification-channel (v1.0.1): Loading from cache
lcobucci/jwt suggests installing mdanter/ecc (Required to use Elliptic Curves based algorithms.)
Writing lock file
Generating autoload files
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover


In Container.php line 960:

  Unresolvable dependency resolving [Parameter #0 [ <required> $app ]] in class Illuminate\Support\Manager

Exception:

[driesvints]

@stevebauman please see #26766 & laravel/vonage-notification-channel#2

[stevebauman]

Thanks @driesvints 😄, that was indeed the issue. To resolve I had to manually delete app/bootstrap/cache/config.php as artisan wouldn't boot properly with this issue so couldn't use php artisan config:clear.

[mfn]

Really, this should not have landed in a minor version :|

See #26689 (comment) and #26689 (comment)

[fitztrev]

@mfn It could be a breaking change. Now, the nexmo/client package and all its dependencies are installed in my app, when before it was just a "suggested" package left for me to decide if I want to use that driver. The nexmo/client package has a number of outdated dependencies:

Package                      Installed  Latest   Description
============================================================================
php-http/guzzle6-adapter     v1.1.1     v2.0.0   Guzzle 6 HTTP Adapter
php-http/httplug             v1.1.0     v2.0.0   HTTPlug, the HTTP client abstraction for PHP
ralouphie/getallheaders       2.0.5      3.0.1   A polyfill for getallheaders.
zendframework/zend-diactoros  1.8.6      2.0.1   PSR HTTP Message implementations

I don't already use any of those but if I did, and had the latest version of any of them installed, it would cause issues.

I noticed on the master branch these have been removed: 88b9fd6

[TBlindaruk]

@driesvints

[driesvints]

@fitztrev At the moment we're not getting any issues about this so I wouldn't revert.

[Kyslik]

Isn't this breaking change? I can not update above 5.7.15 without getting auto-discover error:

Loading composer repositories with package information
Updating dependencies (including require-dev)
Nothing to install or update
Writing lock file
Generating optimized autoload files
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover

In Container.php line 960:

  Unresolvable dependency resolving [Parameter #0 [ <required> $app ]] in cla
  ss Illuminate\Support\Manager

And the stack trace points to nexmo/slack provider.

Note that I cloned my repo and did composer update and it failed with the above message so clearing the bootstrap/cache directory would not help since that is .gitignored.

Obviously not auto-loading the nexmo and slack channels do the trick; but why is this in minor release is beyond me; now I need to change composer.json in every project (where I edited the config #26766 (comment)).

    "extra": {
        "laravel": {
            "dont-discover": [
                "laravel/nexmo-notification-channel",
                "laravel/slack-notification-channel"
            ]
        }
    },

[stevebauman]

Hi @Kyslik, are you sure you cleared the boostrap/cache/config.php file? I literally had the exact same error as you:

#26689 (comment)

You'll have to delete the files manually since artisan will try to auto-load your providers which will generate the same exception.

[Kyslik]

@stevebauman As I mentioned I did git clone... (on brand new machine) && composer update so I did not have the bootstrap/cache/config.php present.

It's solved for me with disabling the auto-discover for those two packages.

[stevebauman]

I understand @Kyslik. Did you add the NotificationServiceProvider to your config/app.php file?

[Kyslik]

@stevebauman no I did not; I am sure that the app I am talking about worked on L5.7.15 (on server its still running like that) I tried to update to latest L5.7.17 on my local machine and got the error about Illuminate\Support\Manager.

[stevebauman]

You will need to add that service provider to get back up and running. Give it a shot and let me know if it works.

[Kyslik]

@stevebauman yes that works as well.

...
\Illuminate\Notifications\NotificationServiceProvider::class,

and removed dont-discover from composer.json

And it works as expected:

> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover
Discovered Package: fideloper/proxy
Discovered Package: laravel/nexmo-notification-channel
Discovered Package: laravel/slack-notification-channel
Discovered Package: laravel/tinker
Discovered Package: nesbot/carbon
Discovered Package: nunomaduro/collision
Package manifest generated successfully.

Thank you :). I still think the change should be in L5.8 instead.

[stevebauman]

@Kyslik Great to hear! And I also agree, but it's already been pushed into a release so oh well 🙁

I don't even use these notification channels so it's somewhat disappointing that we're forced to download these into our projects.