Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.7] Remove the Register <li> when the route doesn't exist instead of leaving it empty #26708

Merged
merged 1 commit into from
Dec 2, 2018
Merged

[5.7] Remove the Register <li> when the route doesn't exist instead of leaving it empty #26708

merged 1 commit into from
Dec 2, 2018

Conversation

tontonsb
Copy link
Contributor

@tontonsb tontonsb commented Dec 2, 2018

This changes around the wrapping of

  • and @if in the layout.

    •

    @tontonsb
    Update app.stub
    c70d88d 
    Remove li (instead of leaving it empty) if the register route is not defined.
    @TBlindaruk TBlindaruk changed the title Remove the Register <li> when the route doesn't exist instead of leaving it empty [5.7] Remove the Register <li> when the route doesn't exist instead of leaving it empty Dec 2, 2018
    @taylorotwell taylorotwell merged commit 5465780 into laravel:5.7 Dec 2, 2018
    @tontonsb tontonsb deleted the patch-1 branch December 2, 2018 18:21
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers
    No reviews
    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    None yet
    2 participants
    @tontonsb @taylorotwell