[5.7] Revert breaking change to assert JSON functions #26713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBlindaruk
changed the title
|
Wouldn't it be wise to add a test for the behaviour that was broken by the changes this attempts to revert? That way, we don't only prevent this mistake now, but we'd also prevent it for the future. |
|
@JeroenVanOort good call. I've sent in a PR which does so: #26741 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts a breaking change that was introduced in cfab97f (released as part of 5.7.14) where assertJsonStructure would throw an exception if the response had numerical string keys (fixes #26677) and where assertJson would throw an exception if the response had an empty object response (instead of throwing a more helpful test failure, fixes #26684).