New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Avoid breaking change of package removal #26727

Merged
merged 2 commits into from Dec 4, 2018

Conversation

Projects
None yet
3 participants
@GrahamCampbell
Member

GrahamCampbell commented Dec 3, 2018

Perhaps we should move these from require to suggest in 5.8?

GrahamCampbell added some commits Dec 3, 2018

@driesvints

This comment has been minimized.

Member

driesvints commented Dec 4, 2018

@GrahamCampbell this seems to break the Travis build.

@GrahamCampbell

This comment has been minimized.

Member

GrahamCampbell commented Dec 4, 2018

Oh, a cyclic dependency. In that case, I think the removal should be reverted in Laravel 5.7, since it's a major breaking change.

@driesvints

This comment has been minimized.

Member

driesvints commented Dec 4, 2018

@GrahamCampbell we've released a fix that move the illuminate/notification requirement for the packages to their require-dev section instead. So the cyclic dependency should be fixed. The build still fails for other reasons which I'm now investigating.

@taylorotwell taylorotwell merged commit 24d51b9 into 5.7 Dec 4, 2018

3 of 4 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@driesvints driesvints deleted the deps branch Dec 4, 2018

driesvints referenced this pull request in laravel/nexmo-notification-channel Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment