Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Add Builder::insertSub() #26732

Merged
merged 8 commits into from
Dec 7, 2018
Merged

[5.7] Add Builder::insertSub() #26732

merged 8 commits into from
Dec 7, 2018

Conversation

miklcct
Copy link
Contributor

@miklcct miklcct commented Dec 4, 2018

This pull requests add the ability of inserting directly from a sub-query at SQL level, without loading data into memory.

Please refer to #2026 for its use.

@miklcct miklcct changed the title [Query builder] add Builder::insertSub() [5.7] add Builder::insertSub() Dec 4, 2018
@GrahamCampbell GrahamCampbell changed the title [5.7] add Builder::insertSub() [5.7] Add Builder::insertSub() Dec 4, 2018
@taylorotwell
Copy link
Member

Is the syntax the same across all supported database drivers?

@miklcct
Copy link
Contributor Author

miklcct commented Dec 6, 2018

*
* @param Builder $query
* @param array $columns
* @param string $sql
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use FQN here and proper spacing between parameters names

@taylorotwell
Copy link
Member

Renamed to insertUsing.

@taylorotwell taylorotwell merged commit 49dad6f into laravel:5.7 Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants