Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Missing localized strings #26751

Merged
merged 1 commit into from
Dec 5, 2018
Merged

[5.7] Missing localized strings #26751

merged 1 commit into from
Dec 5, 2018

Conversation

subotkevic
Copy link
Contributor

Little changes to add localization support for few more strings.

@taylorotwell taylorotwell merged commit f88adea into laravel:5.7 Dec 5, 2018
@GrahamCampbell GrahamCampbell changed the title Missing localized strings [5.7] Missing localized strings Dec 7, 2018
@kkomelin
Copy link

kkomelin commented Jan 14, 2019

@subotkevic @taylorotwell Could you guys please confirm that the default message is not localized twice now?

@section('message', __($exception->getMessage() ?: __('Sorry, you are forbidden from accessing this page.')))

driesvints added a commit that referenced this pull request Jan 14, 2019
@driesvints
Copy link
Member

@kkomelin you're correct. Reverted this.

@kkomelin
Copy link

@driesvints Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants