[5.7] Remove extra alias #26846
Merged
[5.7] Remove extra alias #26846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `Swift_SendmailTransport` is aliased to both `MailTransport` and `SendmailTransport`. We can have both the 'mail' and 'sendmail' drivers build up the same class, and remove the need for the extra alias. I think this also makes it more obvious to the reader that the 'mail' driver doesn't really exist anymore and is actually using sendmail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
Swift_SendmailTransportis aliased to bothMailTransportandSendmailTransport. We can have both the 'mail' and 'sendmail' drivers build up the same class, and remove the need for the extra alias.I think this also makes it more obvious to the reader that the 'mail' driver doesn't really exist anymore and is actually using sendmail.