[5.7] Bug fix for app()->call() #26852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fix for app()->call('class@method');
fixes:
#22687
Added tests for app()->call() with default values in the called method
fixes style-ci issues
Fixes the tests
imanghafoori1
changed the title
imanghafoori1
changed the title
|
I think this PR it is ready. |
Adds more tests
Fix Style-ci
|
I am not sure whether tests for associative array method call syntax are necessary or not. but I jut added them to be really sure. |
This comment has been minimized.
This comment has been minimized.
|
Reverting. Do not send any more PRs for this "feature". |
|
Sorry for that |
This was referenced Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for app()->call('class@method', ['x1' , 'x2', ... ]);
fixes:
#26851
#22687
#26837
The problem is described clearly on the issue and this PR will simply fix it.
And adds unit tests for it.
Let me mention this #22709 PR which has tried to solve the same issue.