New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Allow storage assertions to handle multiple files at once #26975

Merged
merged 4 commits into from Dec 28, 2018

Conversation

Projects
None yet
2 participants
@freekmurze
Copy link
Member

freekmurze commented Dec 28, 2018

This allows assertExists and assertMissing to handle multiple files at once. It also makes them chainable.

Storage::disk('local')
    ->assertExists([
        $path,
        $anotherPath,
    ])
    ->assertMissing([
        $yetAnotherPath,
        $oneMoreFilePath,
    ]);

There are no existing tests for the assertions, so I didn't add any for this new functionality.

freekmurze added some commits Dec 28, 2018

@freekmurze freekmurze changed the title Allow storage assertions to handle multiple files at once [5.7] Allow storage assertions to handle multiple files at once Dec 28, 2018

@taylorotwell taylorotwell merged commit 4cf4dc9 into laravel:5.7 Dec 28, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@freekmurze freekmurze deleted the freekmurze:improve-storage-assertions branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment