[5.7] Fixes broken setHidden method

[nunomaduro]

Not sure if is related to #25342 or #26781, but the setHidden method no longer works as expected.

Issue: When the developer calls the method setHidden that exists the on the Symfony\Command::class, the property $hidden that gets changed it's the private one on the Symfony\Command::class instead of the protected one on the Laravel\Command::class:

$command->setHidden(true);
$command->isHidden(); // returns false

Solution: Add the method setHidden on the Laravel\Command::class to make sure that both attributes have the same value:

    /**
     * {@inheritdoc}
     */
    public function setHidden($hidden)
    {
        parent::setHidden($this->hidden = $hidden);

        return $this;
    }

Result:

$command->setHidden(true);
$command->isHidden(); // returns true

Note: We should consider add some tests on this new hidden related methods. Please close the Pull Request if you want me to add tests on this.

[TBlindaruk]

@nunomaduro , Could you create tests for covered this case?

[Broutard]

Not work for me.
Commands like "schedule:run" still be shown.

It seems it's due to this PR : #26781
If I comment the isHidden() method in Illuminate\Console\Command it works.

[nunomaduro]

@Broutard schedule:run is not hidden on Laravel.

[Broutard]

But it is hidden in my config

'hidden' => [
        NunoMaduro\LaravelConsoleSummary\SummaryCommand::class,
        Symfony\Component\Console\Command\HelpCommand::class,
        Illuminate\Console\Scheduling\ScheduleRunCommand::class,
        Illuminate\Console\Scheduling\ScheduleFinishCommand::class,
        Illuminate\Foundation\Console\VendorPublishCommand::class,
    ],

In fact, the isHidden() method added in #26781 reference the Illuminate\Console\Command protected $hidden variable but when you use setHidden() this is the Symfony\Component\Console\Command\Command method which reference his private $hidden.

[nunomaduro]

@Broutard Seems that you are talking about Laravel Zero. The issue will be fixed when @taylorotwell release the version v5.7.20 of the illuminate/console component.

[Broutard]

Oh, ok sorry I thought it was already done.