New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Do not save the url in session if the call is prefetch #27017

Merged
merged 1 commit into from Jan 1, 2019

Conversation

Projects
None yet
2 participants
@fkeloks
Copy link
Contributor

fkeloks commented Dec 31, 2018

Note: This PR is a resubmission of #26996

Why ?

I noticed using the new features of prefetch that Laravel sessions were working badly.

For example, using this library: GoogleChromeLabs/quicklink, pre-loaded pages modify the session and call the storeCurrentUrl() method. Once connected to the site, the back() method thus redirects the user to a bad url.

Solution

To alleviate this problem, I modified the storeCurrentUrl() function so that it does not save the current URL if the call is of type prefetch.

Sources

@taylorotwell taylorotwell merged commit 97fc8bd into laravel:5.7 Jan 1, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@fkeloks fkeloks deleted the fkeloks:feat_new_prefetch_method branch Jan 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment