[5.7] Fix broken db command code #27020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't see this in the changes. Can you point out where this is? I assume with |
|
Yeh: https://github.com/laravel/framework/pull/27020/files#diff-62bd3530c9c892a12a0b037aa6e0ad10L65. See that |
|
@GrahamCampbell heya, forgive me but I don't see |
|
|
@GrahamCampbell gotcha! |
|
:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can see by the changes to the tests that when force was set to false,
--falsewas still actually being added!!! But, we do want all sub-commands to be forced though, actually, so we should just passtrueto avoid confusion, because it otherwise looks like the user would have been asked again if they want to continue for subcommands, when they are not!The other change is to filter out the defaults, so the empty string is not passed along for no reason.