New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Stop email re-verification with same link #27070

Merged
merged 2 commits into from Jan 5, 2019

Conversation

Projects
None yet
4 participants
@AliN11
Copy link
Contributor

AliN11 commented Jan 5, 2019

If a user reopen the sent email verification link, the email_verified_at column will be updated. While it should not be updated when the email is verified before (by same provided link).

AliN11 added some commits Jan 5, 2019

Stop email reverification with same link
If a user reopen the given email verification link, the `email_verified_at` column is being updated. While in should not be updated when the email is verified before (by same provided link).
Stop email re-verification with same link
If a user reopen the given email verification link, the `email_verified_at` column is being updated. While in should not be updated when the email is verified before (by same provided link).

@AliN11 AliN11 changed the title Stop email re-verification with same link [5.7] Stop email re-verification with same link Jan 5, 2019

@GrahamCampbell

This comment has been minimized.

Copy link
Member

GrahamCampbell commented Jan 5, 2019

This is a breaking change is it not?

@AliN11

This comment has been minimized.

Copy link
Contributor

AliN11 commented Jan 5, 2019

@GrahamCampbell Can you explain more? It breaks what?
Could be considered in 5.8?

@taylorotwell taylorotwell merged commit 04a96d7 into laravel:5.7 Jan 5, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@GrahamCampbell

This comment has been minimized.

Copy link
Member

GrahamCampbell commented Jan 5, 2019

As you said:

If a user reopen the sent email verification link, the email_verified_at column will be updated.

But now that doesn't happen: a breaking change.

@driesvints

This comment has been minimized.

Copy link
Member

driesvints commented Jan 8, 2019

@GrahamCampbell no it's a bug fix. The column shouldn't be updated again if you click this link. @AliN11's pr fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment