New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Update vue preset's vue-stubs for laravel-mix 4 compatibility #27229

Merged
merged 1 commit into from Jan 19, 2019

Conversation

Projects
None yet
4 participants
@cthorne91
Copy link

cthorne91 commented Jan 19, 2019

The stubs for app.js and ExampleComponent.vue when issuing the artisan preset vue command differ from the laravel project's default app.js and ExampleComponent.vue files. Furthermore, the app.js stub is incompatible with laravel-mix 4 because it does not reference .default.

According to the Laravel-Mix 4 upgrade guide https://laravel-mix.com/docs/4.0/upgrade

As part of the vue-loader 15 updates, if your code uses the CommonJS syntax for importing EcmaScript modules, you'll need to append .default...

How to reproduce
Using a fresh install of laravel, issue the php artisan preset vue command.

I'm thinking this was simply overlooked when upgrading laravel to mix 4, or possibly I'm missing something. Hope this PR helps 馃憤

@driesvints driesvints changed the title Update vue preset's vue-stubs for laravel-mix 4 compatibility [5.7] Update vue preset's vue-stubs for laravel-mix 4 compatibility Jan 19, 2019

@taylorotwell taylorotwell merged commit 08eb7a9 into laravel:5.7 Jan 19, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment