Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #27200 #27911

Closed
wants to merge 1 commit into from
Closed

Issue #27200 #27911

wants to merge 1 commit into from

Conversation

jyeany
Copy link

@jyeany jyeany commented Mar 18, 2019

Fix for Issue #27200
Use datetime2 instead of datetime as default
for sql server timestamp columns.
Date format was already updated in Illuminate\Database\Query\Grammars\Query\SqlServerGrammer

Use datetime2 instead of datetime as default
for sql server timestamp columns.
@laurencei
Copy link
Contributor

laurencei commented Mar 18, 2019

your ticket refers to Laravel 5.7, but this is pointed to Laravel 5.5

Either way, it needs to go to the 5.8 branch; or is it considered a breaking change (because it changes the migrations) - and if so then it would need to go to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants