Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Fix the collation bug when changing columns in a migration. #28510

Closed
wants to merge 6 commits into from
Closed

[5.8] Fix the collation bug when changing columns in a migration. #28510

wants to merge 6 commits into from

Conversation

jensdenies
Copy link

This allows the user to add custom schema options to the Doctrine DBAL column. This serves as a fix for #28487.

@driesvints
Copy link
Member

This could use a test. Can you add one? Also needs some StyleCI fixes.

@driesvints
Copy link
Member

This is odd... StyleCI passes but the styling is completely wrong.

@driesvints
Copy link
Member

@GrahamCampbell do you might know why StyleCI passes for these changes but the styling is completely different than what the .styleci.yml file requires? https://github.com/laravel/framework/blob/5.8/.styleci.yml

@jensdenies
Copy link
Author

@driesvints I've added a test, please let me know what you think. By the way, StyleCI shouldn't check the "tests" directory, right?

@driesvints
Copy link
Member

@JacksonIV it should but there's something really wrong with this PR for some reason. I need @GrahamCampbell's input before we proceed.

This isn't by coincidence a really old branch from before we added the StyleCI config file?

@jensdenies
Copy link
Author

@driesvints That could be the problem. I'll send in a new PR.

@jensdenies jensdenies closed this May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants