Revert "[5.8] Add 'index' => 'viewAny' to resourceAbilityMap"#28865
Merged
Conversation
Contributor
|
I wouldn't revert it, as it's on par with nova behaviour as I've read it. |
Member
|
@danijelk no breaking changes, even small ones, are allowed on 5.8. |
Contributor
|
Just request a test to be made to avoid future confusion again, problem
solved 😊
Could someone make this PR for 5.9?
|
Contributor
|
I think @danijelk 's point is a breaking change already made it through. Need a test to prevent this from happening again. |
Contributor
Author
|
ping @clement-jacquet - if you can re-submit your original PR and send to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #28820
Breaking change. See #28862
Although do we just "press forward" since reverting might also be a BC now if anyone depending on new behaviour? I'll leave it for Taylor to decide.