Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[5.8] Add 'index' => 'viewAny' to resourceAbilityMap" #28865

Merged
merged 1 commit into from Jun 17, 2019

Conversation

Projects
None yet
4 participants
@laurencei
Copy link
Member

commented Jun 17, 2019

Reverts #28820

Breaking change. See #28862

Although do we just "press forward" since reverting might also be a BC now if anyone depending on new behaviour? I'll leave it for Taylor to decide.

@danijelk

This comment has been minimized.

Copy link

commented Jun 17, 2019

I wouldn't revert it, as it's on par with nova behaviour as I've read it.
The only thing I would do is to set a default return true on viewAny guard to make it BC. But that's also risky.

@taylorotwell taylorotwell merged commit 0ab884f into 5.8 Jun 17, 2019

4 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@taylorotwell

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

@danijelk no breaking changes, even small ones, are allowed on 5.8.

@danijelk

This comment has been minimized.

Copy link

commented Jun 17, 2019

@browner12

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

I think @danijelk 's point is a breaking change already made it through. Need a test to prevent this from happening again.

@GrahamCampbell GrahamCampbell deleted the revert-28820-abilityMap branch Jun 17, 2019

@laurencei

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2019

ping @clement-jacquet - if you can re-submit your original PR and send to the master branch to be included in 5.9?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.