[6.0] Fix incorrect HTTP OPTION verb #29828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhedger
changed the title
|
@taylorotwell The same error exists on Lumen 5.8. Should I create a new PR or will this get merged into Lumen eventually ? https://github.com/laravel/lumen-framework/blob/5.8/src/Testing/Concerns/MakesHttpRequests.php#L138-L153. Regards. |
|
@nhedger best to send to master on that repo |
|
Will do, thanks. |
|
I guess this error shows nobody uses this code? |
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
As I was testing a new app I'm working on, I stumbled across the
optionandoptionJsonmethods inIlluminate\Foundation\Testing\Concerns\MakesHttpRequests. I had weird exceptions so I decided to dig a little.I believe a mistake was introduced in #29258 because the HTTP
OPTIONmethod does not exist but theOPTIONSone does.For reference : https://tools.ietf.org/html/rfc7231#section-4