[6.x] Resolve class command via application resolution #29869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xel1045
force-pushed
the
resolve-command-via-application-resolution
branch
from
3599cb2
to
0b07e0f
Compare
|
No plans on changing this at the moment. I believe you can inject dependencies into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From a Laravel command, we can actually invoke another command using
$this->call(Command::class);or$this->callSilent(Command::class);. This allows developers to navigate through the code and identify where a command is used.Unfortunately, application resolution is not used in those cases and it makes class injection impossible. This PR replace the
new $commandfor a class resolution via the application.