[6.x] Add events to signal when scheduled task runs

[michaeldyrynda]

We already have the Illuminate\Console\Events\CommandStarting and Illuminate\Console\Events\CommandFinished events, but these are fired for any command that is run, be it via the CLI directly, or via schedule:run.

Having the scheduled-task specific events makes it much easier to identify when a scheduled task runs, allowing better monitoring of these tasks in a more dynamic manner.

[taylorotwell]

On single server events it seems to fire even when the event is never actually run on the given server.

[michaeldyrynda]

Right you are. I’ll update this PR to get the events to dispatch only within the runEvent method.

[michaeldyrynda]

Should be good for another look @taylorotwell

[driesvints]

@michaeldyrynda definitely not a requirement but any chance you can use rebase instead of merging in the 6.x branch into your PR? Keeps the commit history nice and clean.

[michaeldyrynda]

Did the rebase @driesvints 😘

[simonschaufi]

Out of curiosity, shouldn't the new tag be 6.1 for new features?

MINOR version when you add functionality in a backwards compatible manner

[GrahamCampbell]

Yeh, it should have been.

[michaeldyrynda]

The rest of that line says “... to the public API.”

It’s not clear to me if adding events is part of the public API, though. For the record, I was expecting a minor bump with this change, but it’s a gray area imo.

The other stuff that went into this release added test helper methods and I feel that those aren’t public API of the framework, either.