Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] allow adding NotFoundHttpException to "allowed" exceptions in tests #29975

Merged
merged 1 commit into from
Sep 12, 2019

Conversation

kbond
Copy link
Contributor

@kbond kbond commented Sep 12, 2019

Currently, it is not possible to have:

/**
 * @test
 */
public function my_test()
{
    $this->handleExceptions([
        NotFoundHttpException::class,
    ]);

    // ...
}

This is because the checking for NotFoundHttpException happens before checking the "excepts" in InteractsWithExceptionHandling. This PR ensures checking for "excepts" happens first.

@taylorotwell taylorotwell merged commit c759a65 into laravel:6.x Sep 12, 2019
@kbond kbond deleted the suppress-not-found-exceptions branch September 12, 2019 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants