[6.x] Add assertion method for 201 Created HTTP response #30368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmirrezaNasiri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new
assertCreatedmethod toIlluminate\Foundation\Testing\TestResponse. It basically asserts that response code equals to201in a more elegant way thanassertStatus(201).The reason behind this assertion method is that Eloquent API Resources response with a
201code if the model is just created and this is a case which is widely expected on CRUDs for example. In other hand, there is no similar method toisCreatedon base HTTP Response thus we have to assert201code directly.