Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Reattach bcc to $message for post events #30569

Merged
merged 2 commits into from Nov 12, 2019
Merged

Conversation

@danijelk
Copy link
Contributor

danijelk commented Nov 12, 2019

This will ensure that the bcc header isn't empty in events such as MessageSent.

This will ensure that the bcc header isn't empty in events such as MessageSent.
@driesvints driesvints changed the title reattach bcc to $message for post events [6.x] Reattach bcc to $message for post events Nov 12, 2019
@driesvints

This comment has been minimized.

Copy link
Member

driesvints commented Nov 12, 2019

Isn't there a specific reason why it's cleared in the first place? Isn't this also a change in behavior and aren't people atm expecting it to be empty?

@danijelk

This comment has been minimized.

Copy link
Contributor Author

danijelk commented Nov 12, 2019

Isn't there a specific reason why it's cleared in the first place? Isn't this also a change in behavior and aren't people atm expecting it to be empty?

We tried to check history, but couldn't see any valid reason. Was hoping someone could tell us otherwise with this PR as it fixes an issue for us in our event listener.

@danijelk

This comment has been minimized.

Copy link
Contributor Author

danijelk commented Nov 12, 2019

Also if this is expected behaviour then the SES driver should clear the Bcc to have the same outcome. That's why we believe that the Mailgun & old sparkpost drivers did it wrong.

@taylorotwell taylorotwell merged commit d552777 into laravel:6.x Nov 12, 2019
1 check passed
1 check passed
continuous-integration/styleci/pr The analysis has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.