[6.x] Reattach bcc to $message for post events #30569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will ensure that the bcc header isn't empty in events such as MessageSent.
driesvints
changed the title
|
Isn't there a specific reason why it's cleared in the first place? Isn't this also a change in behavior and aren't people atm expecting it to be empty? |
We tried to check history, but couldn't see any valid reason. Was hoping someone could tell us otherwise with this PR as it fixes an issue for us in our event listener. |
|
Also if this is expected behaviour then the SES driver should clear the Bcc to have the same outcome. That's why we believe that the Mailgun & old sparkpost drivers did it wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure that the bcc header isn't empty in events such as MessageSent.