Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Add new validateWithBag macro to Request #30896

Merged
merged 1 commit into from Dec 23, 2019

Conversation

@paulhenri-l
Copy link
Contributor

paulhenri-l commented Dec 21, 2019

Add new validateWithBag macro to the Request class.

This method will allow people to specify the name of the bag validation errors should be put in.

Why?

This convenience method already existed in the ValidatesRequests trait.

Adding it as a macro will help people keep their code consistent and either stick to the Request macros for validation or the ValidatesRequests trait.

@taylorotwell taylorotwell merged commit fdeb204 into laravel:6.x Dec 23, 2019
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@taylorotwell

This comment has been minimized.

Copy link
Member

taylorotwell commented Dec 23, 2019

Can you make a PR to document this. Nice work.

@paulhenri-l

This comment has been minimized.

Copy link
Contributor Author

paulhenri-l commented Dec 23, 2019

@taylorotwell Sure I'll do that

@paulhenri-l paulhenri-l deleted the paulhenri-l:validate-request-with-bag branch Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.