/ framework Public
[6.x] Speed up runningInConsole method #30922
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
This code is actually quite hot, since it's called by most (package) service providers.
The new code is faster because:
Env::getisn't all that cheap, in the case where the env variable was found in the last place we look, and so we should only call it once, and assign the result.
return php_sapi_name() === 'cli' || php_sapi_name() === 'phpdbg';with either
return false;, since it is able to replace the constant (that it knows is global due to the slash) with the string value, and then it can evaluate the equality and or, all ahead of time.
I detected this optimization when profiling a Laravel app with xdebug tracing btw. ;)