[6.x] Adds missing options for PhpRedis #31182
Conversation
|
The serializer option doesnt seem to be working. The $option variable you reference in vendor/laravel/framework/src/Illuminate/Redis/Connectors/PhpRedisConnector.php:101 is never set, so it will never get into the if block |
| @@ -97,6 +97,14 @@ protected function createClient(array $config) | |||
| if (! empty($config['read_timeout'])) { | |||
| $client->setOption(Redis::OPT_READ_TIMEOUT, $config['read_timeout']); | |||
| } | |||
|
|
|||
| if (! empty($options['serializer'])) { | |||
There was a problem hiding this comment.
I just tested and confirm that $options isn't in this scope, as it is within createRedisClusterInstance which is probably what @Wizofgoz uses.
|
Any status on this bug? Would be a good idea to add OPT_COMPRESSION_LEVEL & OPT_COMPRESSION while we're on this missing options issue. I should be able to do a new PR tomorrow if no one else has the time @Wizofgoz @driesvints |
|
@danijelk feel free to send in a pr. Make sure you add a thorough description it. |
|
I briefly looked into it and it looks like I copy/pasted between |
This PR adds support for options on PhpRedis connections that were not allowed before. This includes specifying a serializer, scan option, and failover behavior for cluster connections.
The serializer option allows for using igbinary which can use significantly less storage space as documented here.
The scan option allows for customizing the behavior of scan commands as described here.
The failover option allows for customizing the behavior of a cluster connection as described here.
Replaces #31021