[6.x] Fix channel names when broadcasting via redis #31261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression from laravel#31108
GrahamCampbell
changed the title
driesvints
reviewed
Jan 28, 2020
GrahamCampbell
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#31108 introduced publishing events to multiple channels at once using a Lua script. When publishing events through the Lua script, the
Redis::OPT_PREFIXoption does not apply and needs to be prepended manually.Fixes in external projects:
Fixes tlaverdure/laravel-echo-server#477
Fixes tlaverdure/laravel-echo-server#407