Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Remove serializer option for now #31417

Merged
merged 1 commit into from Feb 10, 2020
Merged

Conversation

@driesvints
Copy link
Member

driesvints commented Feb 10, 2020

Apparently when #31393 was merged it broke the test suite because the test suite was now actually running with the proper tests to verify the serializer behavior. This actually showed that the serializer option never worked in the first place.

This PR will remove the broken serializer option for now. If anyone wants to tackle implementing it again with passing tests they can attempt a new PR.

I also fixed two incorrect variable names.

@driesvints driesvints force-pushed the remove-redis-serializer-option branch from 9e20ec6 to 87e7c0d Feb 10, 2020
@taylorotwell taylorotwell merged commit 95a8f05 into 6.x Feb 10, 2020
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
@driesvints driesvints deleted the remove-redis-serializer-option branch Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.