[6.x] Remove serializer option for now #31417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
force-pushed
the
remove-redis-serializer-option
branch
from
9e20ec6
to
87e7c0d
Compare
|
maybe because just $option array instead of $config array ? igbinary better and faster! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently when #31393 was merged it broke the test suite because the test suite was now actually running with the proper tests to verify the serializer behavior. This actually showed that the serializer option never worked in the first place.
This PR will remove the broken serializer option for now. If anyone wants to tackle implementing it again with passing tests they can attempt a new PR.
I also fixed two incorrect variable names.