Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] SQLite JSON update support with json_patch #31492

Merged
merged 2 commits into from Feb 18, 2020

Conversation

@iamgergo
Copy link
Contributor

iamgergo commented Feb 15, 2020

This is a retry of #31472, but using json_patch instead of json_set.


  • The currently compiled SQL is invalid when trying to update nested JSON fields (details in the previous PR).
  • SQLite is a very nice solution when testing small packages or very light applications that may still use JSON columns. In those cases using SQLite for testing purposes is a huge time saver.
  • No one expects a robust JSON support for SQLite, but for smaller tests, this can serve perfectly and no need to set up a MySQL or a PostgreSQL database. So, it might be a good idea, supporting JSON column updates in SQLite's Grammar (especially, since there are native functions we can use, this is not a regex replacer or something like that).

By grouping the nested JSON updates (selectors using ->), we can use a single json_patch to update the JSON column. Also, filtering JSON selectors, prevents generating invalid SQL.

The json_patch will merge the grouped attributes to the currently stored JSON in the database, so it updates only the values we want to update. Also, this approach guards the parameter order.

An Eloquent update query like the following will update the desired columns properly:

Customer::whereIn('id', [1, 2, 3])->update([
    'meta->size' => 'L',
    'options->security' => ['2fa'],
    'group_id' => 30,
    'meta->color' => 'Yellow',
]);

This PR contains no beaking change as far as I know.

@taylorotwell taylorotwell merged commit a8c3791 into laravel:6.x Feb 18, 2020
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.