Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Add lcfirst #31503

Closed
wants to merge 3 commits into from
Closed

[6.x] Add lcfirst #31503

wants to merge 3 commits into from

Conversation

Isa3v
Copy link

@Isa3v Isa3v commented Feb 17, 2020

No description provided.

@GrahamCampbell GrahamCampbell changed the title Add lcfirst [6.x] Add lcfirst Feb 17, 2020
@rimace
Copy link
Contributor

rimace commented Feb 17, 2020

I guess the reason behind not just calling PHP's lcfirst is because it ignores non-ascii characters, right?
This could be easily overlooked when someone "optimizes" methods, so a unit test that calls Str::lcfirst('Ä') and expects ä would be helpful.

@taylorotwell
Copy link
Member

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.

Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants