[6.x] Fix loading deferred providers for binding interfaces and implementations #31629
Conversation
…e accessing class through interface
This commit brings back behaviour from Laravel 5.7 when you could use deferred provides to bind an interface to implementation even when implementation had its own deferred provider. Changing `resolve` method to `make` results in calling `Illuminate\Foundation\Application::make` method which loads deferred providers. Calling `resolve` method calls `Illuminate\Container\Container::resolve` which does not load deferred providers.
| @@ -261,7 +261,7 @@ protected function getClosure($abstract, $concrete) | |||
| return $container->build($concrete); | |||
| } | |||
|
|
|||
| return $container->resolve( | |||
| return $container->make( | |||
There was a problem hiding this comment.
The make method is just an alias of resolve. This can't solve anything really.
There was a problem hiding this comment.
It solves the issue. Try checking out previous commit where test was added. Resolve is an alias of make in Illuminate\Container\Container, but not in Illuminate\Foundation\Application.
There was a problem hiding this comment.
@driesvints it actually could in the context of an application because the Foundation Application overrides make to do the deferred provider stuff.
| * @return mixed | ||
| * | ||
| * @throws \Illuminate\Contracts\Container\BindingResolutionException | ||
| */ | ||
| public function make($abstract, array $parameters = []) | ||
| public function make($abstract, array $parameters = [], $raiseEvents = true) |
There was a problem hiding this comment.
Changing the method signature here is unfortunately a breaking change.
|
Why all the |
|
The problem here really is that the things happening in |
To be honest I don't know how |
|
One solution may be to make the extra stuff in Application |
This reverts commit 8943aad.
It allows resolving object by interface when using separate deferred providers for interface and implementation.
|
Good idea, I've updated the PR. Tests are OK and signatures are intact. |
This PR is the effect of discussion in #31588
It brings back behaviour from Laravel 5.7 when you could use deferred provides to bind an interface to implementation even when implementation had its own deferred provider. Changing
resolvemethod tomakeresults in callingIlluminate\Foundation\Application::makemethod which loads deferred providers. Callingresolvemethod callsIlluminate\Container\Container::resolvewhich does not load deferred providers.I'm targeting 6.x as it is stated in contribution guide, but in my opinion it may also be good to apply it to 5.8 for the sake of compatibility when migrating gradually from 5.7 to 5.8 and then to 6.x.