Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Escape attributes automatically in some situations #31945

Merged
merged 7 commits into from Mar 13, 2020
Merged

Conversation

@taylorotwell
Copy link
Member

taylorotwell commented Mar 12, 2020

No description provided.

@GrahamCampbell GrahamCampbell changed the title Escape attributes automatically in some situations [7.x] Escape attributes automatically in some situations Mar 12, 2020
@@ -165,15 +176,15 @@ protected function componentString(string $component, array $attributes)
if (! class_exists($class)) {
$parameters = [
'view' => "'$class'",
'data' => '['.$this->attributesToString($data->all()).']',
'data' => '['.$this->attributesToString($data->all(), $escapeBound = false).']',

This comment has been minimized.

Copy link
@perifer

perifer Mar 13, 2020

Contributor

This is currently not covered by any test (Changing to $escapeBound = true doesn't cause any tests to fail).

This comment has been minimized.

Copy link
@perifer

perifer Mar 13, 2020

Contributor

Here is an attempt to cover this in testClasslessComponents(): perifer@46176c6

This comment has been minimized.

Copy link
@taylorotwell

taylorotwell Mar 13, 2020

Author Member

Thanks

@taylorotwell taylorotwell merged commit ae4d790 into 7.x Mar 13, 2020
14 checks passed
14 checks passed
P7.2 - Sprefer-lowest
Details
P7.2 - Sprefer-lowest
Details
P7.2 - Sprefer-stable
Details
P7.2 - Sprefer-stable
Details
P7.3 - Sprefer-lowest
Details
P7.3 - Sprefer-lowest
Details
P7.3 - Sprefer-stable
Details
P7.3 - Sprefer-stable
Details
P7.4 - Sprefer-lowest
Details
P7.4 - Sprefer-lowest
Details
P7.4 - Sprefer-stable
Details
P7.4 - Sprefer-stable
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
@GrahamCampbell GrahamCampbell deleted the escape-attributes branch Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.