Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Alias eloquent with-relationships #31976

Closed
wants to merge 1 commit into from

Conversation

crissi
Copy link
Contributor

@crissi crissi commented Mar 15, 2020

This pr enables relationships to be loaded with an alias name.

this allows you to use the same relationship multiple times with different constraints which is not possible today. Today you will have to add new relationships to the model to accomplish this.

This aligns the with-method with the withCount-method which supports aliases today: https://laravel.com/docs/7.x/eloquent-relationships#counting-related-models

For me personally I have a need for this with a graphql library that uses eloquent to create eager loaded queries. Since graphql supports aliases I would need to create different versions of relationship if an alias is used with different params that might change the constraints.

$user = EloquentTestUser::with([
            'posts as aliasPosts' => function($q) {
                $q->where('name', 'Second Post');
            },
            'posts.childPosts' => function($q) {
            },
            'posts.childPosts AS aliasChildPosts' => function($q) {
                $q->where('name', 'Child Post2');
            }
        ])->first();

@GrahamCampbell GrahamCampbell changed the title Alias eloquent with-relationships [8.x] Alias eloquent with-relationships Mar 15, 2020
Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the phpdoc for the functions whose signatures you have changed.

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

@PaolaRuby
Copy link
Contributor

Closed only for not update the phpdoc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants