[7.x] Optimize container#32194
Merged
taylorotwell merged 2 commits intolaravel:7.xfrom Apr 2, 2020
nguyenyou:optimize-container
Merged
[7.x] Optimize container#32194taylorotwell merged 2 commits intolaravel:7.xfrom nguyenyou:optimize-container
taylorotwell merged 2 commits intolaravel:7.xfrom
nguyenyou:optimize-container
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I saw is the
getContextualConcretemethod is called twice during the execution of theresolvemethod, in case the given$parametersis empty.We're able to make it to be called once by capturing its return value, and then before calling the
getConcretemethod, we will check if that value is null. If the value is not null, just use it.The behavior is exactly the same, the benefit is reducing an unnecessary method call.