[7.x] Optimize Str::startsWith() #32243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
Str::startsWith
around 10% faster by usingstrncmp
.There have been two PRs in the past that have tried to optimize this method using
strpos
: #30952 and #16761. Usingstrpos
is not a good idea, this comment on a previous PR explains why.Benchmark
substr
implementationstr_repeat('test', 2000)
str_repeat('test', 20)
str_repeat('test', 2000)
str_repeat('nope', 20)
str_repeat('test', 2000000)
str_repeat('test', 2000000)
str_repeat('test', 2000000)
strpos
implementationstr_repeat('test', 2000)
str_repeat('test', 20)
str_repeat('test', 2000)
str_repeat('nope', 20)
str_repeat('test', 2000000)
str_repeat('test', 2000000)
str_repeat('test', 2000000)
strncmp
implementation proposed in this PRstr_repeat('test', 2000)
str_repeat('test', 20)
str_repeat('test', 2000)
str_repeat('nope', 20)
str_repeat('test', 2000000)
str_repeat('test', 2000000)
str_repeat('test', 2000000)
Benchmark code