Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Fix setting mail header #32272

Merged
merged 1 commit into from Apr 7, 2020
Merged

[6.x] Fix setting mail header #32272

merged 1 commit into from Apr 7, 2020

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Apr 7, 2020

Replaces #32271

@taylorotwell taylorotwell merged commit bf4b6d1 into 6.x Apr 7, 2020
@GrahamCampbell GrahamCampbell deleted the fix-mail-headers branch April 7, 2020 14:38
@ghost
Copy link

ghost commented Apr 7, 2020

Hi,
We've literally just found an issue with this PR, where if you add an attachment (ours was a calendar ics file) then the html email body is sent as raw html. When we downgraded from 6.18.4 to 6.18.3 this issue was resolved. Thought you would like to know. Here is a screengrab of what we were getting in 6.18.4

Screenshot 2020-04-07 at 19 20 19

Hope that helps;
The mail was run using the following command (filenames removed for security);
public function build() { return $this->view('xxxxxxxx')->attachData($this->ics, 'xxxxx.ics', ['mime' => "text/calendar"]); }

driesvints added a commit that referenced this pull request Apr 7, 2020
@driesvints
Copy link
Member Author

@bengallienne We're reverting this change. Thanks for notifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants