[7.x] Added new Stringable::leftTrim() and Stringable::rightTrim() methods#32288
Merged
taylorotwell merged 2 commits intoApr 8, 2020
Conversation
Member
|
I would name them |
Contributor
Author
|
@taylorotwell All done 🙂 |
This was referenced Apr 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
trim()method already existed, but the neighbouringleftTrim()andrightTrim()methods were missing.If they're not wanted in the framework, I can always macro them in but I think there would be quite a few use cases where you only want to trim from one end of the string, not both.