Repository navigation
[7.x] Added appends($attributes) method to Eloquent collections - #32324
Merged
Merged
Conversation
GrahamCampbell
requested changes
Apr 11, 2020
This reverts commit 8053f6d.
GrahamCampbell
requested changes
Apr 11, 2020
Contributor
Author
|
@GrahamCampbell it should be fixed now, if not can you point me in the direction where I'm going wrong? :) |
|
Won't that cause confusion with expected behavior ( |
salmanarshad321
pushed a commit
to salmanarshad321/framework
that referenced
this pull request
Sep 23, 2026
…vel#32324) * Added appends($attribute) method to Eloquent Collections * Revert "Added appends($attribute) method to Eloquent Collections" This reverts commit 8053f6d. * Fixed styling * Fixed docblock styling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Much like the
makeVisible($attributes)andmakeHidden($attributes)methods,appends($attributes)allows the developer to utilize Laravel's accessors to append specific attributes across an entire eloquent collection.If you wan't to achieve something similar right now, you would have to do something like this:
Otherwise your only option is to specify the attributes to be appended directly within the model, where it will be appended every time.
The downside here is that you'd have to remove/unset/hide the attribute whenever you don't need that specific one.
As an end user, this method allows me to more quickly choose when certain attributes should be appended.
The method has simply been added to the Collections.php class and should not cause any breaking changes.