[7.x] Fix unit test routes when base url has a trailing slash

[SjorsO]

I ran a composer update today that updated the framework from 7.3.0 to 7.5.2. This broke some of my unit tests.

Turns out the issue was that my APP_URL had a trailing slash: http://st.test/. Because only the URI is trimmed, and not the base url, this caused a double slash in my url: http://st.test//tools. This has never been a problem, but apparently this somehow broke between 7.3.0 and 7.5.2.

The tests that broke looked something like this:

$this->get('/tools')->assertStatus(301);

The routes couldn't be found anymore after the update, and returned a 404.

[GrahamCampbell]

Thanks for this. I think the real bug here is that we are hackily calling the foundation config function instead of asking the router for the absolute url.

[GrahamCampbell]

#32345 should fix your issue, after it is merged and a 6.x -> 7.x merge has occurred.

[GrahamCampbell]

This should be fixed in tomorrow's release. :)

[SjorsO]

Glad to hear! I already fixed it for myself by just removing the trailing slash 😄